Repository navigation
feat: Add Minors field - #117
Merged
Merged
Conversation
…le pages, and updates for the other user.
✅ Deploy Preview for redi-love ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nadia-choop
requested review from
abrar-amin,
clementroze,
glopes2023,
jacquelinecai and
laylaliuuu
March 17, 2026 20:52
glopes2023
reviewed
Mar 17, 2026
glopes2023
approved these changes
Mar 17, 2026
glopes2023
left a comment
glopes2023
left a comment
Contributor
There was a problem hiding this comment.
I left one quick comment about the suggestions filter, but otherwise looks good to me!
jacquelinecai
approved these changes
Mar 18, 2026
jacquelinecai
left a comment
jacquelinecai
left a comment
Collaborator
There was a problem hiding this comment.
Great work Nadia! Just have one minor fix and you should be good to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates to the Edit Profile and Preview Profile pages, and updates for the other user.
Test Plan
Redi_minors_feature.mov
Most testing functionality
Redi_Minor_field_norepeats.mov
No repeated majors/minors demo
Note: will add sc/screen recording of other user perspective when able to log in to another acc matched w Sona
Notes
Minors taken from official Cornell page
Breaking Changes
None