Repository navigation
♻️ Redesign member forms, dev portfolios, and coffee chat bingo - #1229
clementroze wants to merge 12 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
[diff-counting] Significant lines: 5591. This diff might be too big! Developer leads are invited to review the code. |
| return; | ||
| } | ||
| await APIWrapper.delete(`${backendURL}/coffee-chat/${uuid}`); | ||
| const res = await APIWrapper.delete(`${backendURL}/coffee-chat/${uuid}`); |
There was a problem hiding this comment.
this is for checking the delete response so a failed request shows an error instead of removing the coffee chat from the UI
| if (options?.throwOnError && (!val || val.error)) { | ||
| throw new Error(val?.error || 'Could not load shoutouts.'); | ||
| } |
There was a problem hiding this comment.
optional error throwing so that new UI can show retry state instead of empty result
There was a problem hiding this comment.
these files (and the next few after) are just to update the breadcrumbs path in the header correctly, cuz sometimes they're a bit wack (wrong parent, wrong child, etc.)
| <BaseCombobox.Empty> | ||
| <span className={inputStyles.emptyMessage}>No matches found.</span> |
| <Dialog.Popup | ||
| {...popupProps} | ||
| id={id} | ||
| className={styles.modal} | ||
| style={width ? { width } : undefined} | ||
| > |
There was a problem hiding this comment.
for dynamically sized modals
| <aside className={styles.periods} aria-label="Credit periods"> | ||
| {tecDeadlines.map((deadline, index) => ( | ||
| <Card | ||
| key={deadline.toISOString()} | ||
| header={index === period ? 'Current' : ['Past', 'Upcoming'][Number(index > period)]} | ||
| > | ||
| <h2 className={styles.periodTitle}>Period {index + 1}</h2> | ||
| <p> | ||
| Ends:{' '} | ||
| {deadline.toLocaleDateString('en-US', { | ||
| weekday: 'short', | ||
| month: 'short', | ||
| day: 'numeric', | ||
| timeZone: 'UTC' | ||
| })} |
|
|
||
| type Route = { label: string; parent?: string }; | ||
|
|
||
| /** Navigation hierarchy is explicit because several detail URLs are siblings of their list. */ |
There was a problem hiding this comment.
honestly this is just hardcoding the paths but i think if we have a better sidebar hierarchy/organization, eventually will become more intuitive
| const { enabled, setEnabled } = usePreviewToggle(); | ||
| const [minimized, setMinimized] = useState(false); | ||
| const [hasInstance, setHasInstance] = useState(false); | ||
| const [profilePhoto, setProfilePhoto] = useState<string>(); |
6095ccf to
91dd725
Compare





Summary
Stacked on #1228. This PR targets
clement-idol-redesign-1and contains the next layer of the IDOL redesign.Pics
Notion/Figma Link
IDOL redesign — Dev Portfolio reference
Notes
main