Skip to content

Edit Items While Creating a Fundraiser - #176

Merged
Arsh-S merged 3 commits into
mainfrom
edit-items-on-create
Oct 27, 2026
Merged

Arsh-S merged 3 commits into
mainfrom
edit-items-on-create

Conversation

@jiminkim214

@jiminkim214 jiminkim214 commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Sellers can edit a listing while creating a fundraiser, instead of deleting it and adding it again to fix a typo or price. The creation step also says items can be edited again after the fundraiser is created.

Changes

  • the Add Items step reuses ItemDialog, with the same pencil and remove icons as the later item editor
  • ItemDialog can save into the creation form before a fundraiser exists
  • the review step notes that items stay editable after creation

Tests

Screen.Recording.2026-10-25.at.12.47.21.AM.mov

@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
curaise Ready Ready Preview Oct 27, 2026 9:00pm UTC

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 1f07cc2b-7458-4706-9f3f-5e9c7a30aeb6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eicyer eicyer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also ran manuel checks with the inventory.

create-fundraiser now imports ItemDialog from seller/fundraiser/[id]/components/. Would you rather move it to a shared folder like components/custom, so one route isn't reaching into another's components?

Also EMPTY_ITEM in FundraiserAddItemsForm duplicates DEFAULT_ITEM_VALUES from EditItems. Could you import that instead, or do you want to keep them separate on purpose?

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jiminkim214
❌ Arsh-S
You have signed the CLA already but the status is still pending? Let us recheck it.

@Arsh-S
Arsh-S merged commit 6663f6e into main Oct 27, 2026
5 checks passed
@Arsh-S
Arsh-S deleted the edit-items-on-create branch October 27, 2026 21:06

This branch was successfully deployed

1 active deployment
Preview — aade46fb Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants