Repository navigation
Check mailgun signature - #171
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hi Amber, thank you for the bug fix! A few changes: for the DKIM failure, it is better to return 406 instead of 401 so that it won't retry constantly at an interval. Also, please resolve the merge conflict |
Arsh-S
left a comment
There was a problem hiding this comment.
Thanks Amber, looks good! One gap: the DKIM check only looks at the first DKIM-Signature header, so a fake d=venmo.com header in front of a real signature from another domain would pass. Check all of them. I'll handle the rebase after. @ambers7
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
…ignature # Conflicts: # backend/jest.config.js # backend/package.json # pnpm-lock.yaml
Summary
Checks that the Mailgun signature is from Mailgun and that the email was cryptographically signed by venmo.com, instead of someone changing the webhook POST to show being sent by Mailgun or changing the email to show Venmo.
TODO:
How to test
Test with

npx jest email.handlers.test.tsinbackend