Skip to content

add OnUpgrade callback#3

Open
kokizzu wants to merge 1 commit into
coredns:masterfrom
kokizzu:onupgrade-callback
Open

add OnUpgrade callback#3
kokizzu wants to merge 1 commit into
coredns:masterfrom
kokizzu:onupgrade-callback

Conversation

@kokizzu

@kokizzu kokizzu commented May 4, 2023

Copy link
Copy Markdown

related to this: coredns/coredns#6074

so all plugin that require releasing port can add themself to this callback.

@chrisohaver

Copy link
Copy Markdown
Member

Maybe instead of adding a new callback, call existing OnShutdown callbacks during Upgrade?

@kokizzu

kokizzu commented May 5, 2023

Copy link
Copy Markdown
Author

Just not sure if this will affect every plugin and giving unexpected behavior instead of just plugins that require closing socket

@kokizzu

kokizzu commented May 5, 2023

Copy link
Copy Markdown
Author

yup, can't do, if i call shutdown before upgrade, it would change a lot of plugins behavior because normally OnShutdown called after new forked process is up, so it's better to call different event (OnUpgrade) instead (or maybe name this OnBeforeUpgrade?)

Signed-off-by: Kiswono Prayogo <kiswono@gmail.com>
@kokizzu kokizzu force-pushed the onupgrade-callback branch from 81dc9f3 to 6fb0d95 Compare May 5, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants