fw/quick_launch: split picker into "actions" and "apps" - #1975
Open
josiahcbloomer wants to merge 3 commits into
Open
fw/quick_launch: split picker into "actions" and "apps"#1975josiahcbloomer wants to merge 3 commits into
josiahcbloomer wants to merge 3 commits into
Conversation
The "disable" Quick Launch action previously would open the Quick Launch settings menu, which means there was no actual option to "do nothing." Renamed the current "Disable" option to "Unassigned", and added a new "Nothing" action that actually does nothing. "Unassigned" is still the default. Fixes coredevices#1763 Signed-off-by: Josiah Bloomer <josiah@bloomer.cc> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Toggle actions were mixed with app launches in a single list. Split the list into two sub-menus for UX clarity. Signed-off-by: Josiah Bloomer <josiah@bloomer.cc> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Added "Toggle" to the beginning of some of the Quick Launch toggle actions, making their purpose more clear. "Airplane Mode" > "Toggle Airplane Mode" "Backlight" > "Toggle Backlight" "Motion Backlight" > "Toggle Motion Backlight" "Quiet Time" > "Toggle Quiet Time" Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Josiah <josiah@bloomer.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggle actions were mixed with app launches in a single list. Split the list into two sub-menus for UX clarity - one for "Apps" and one for "Actions." This could make it easier to add more actions in the future without clutter.
Renamed toggle actions to add "Toggle" in front of them (e.g. "Airplane Mode" is now "Toggle Airplane Mode").
Tests pass. Built and tested on PT2.
