applib/recognizer: drive the dead-zone fallback and make it geometric - #1893
Draft
Mearman wants to merge 1 commit into
Draft
applib/recognizer: drive the dead-zone fallback and make it geometric#1893Mearman wants to merge 1 commit into
Mearman wants to merge 1 commit into
Conversation
The status-bar dead-zone branch in prv_resolve_route answers Tier-1 for the window's sole registered widget, but prv_resolve_widget_target only walks the active layer's parent chain -- which by construction already failed, or the dead-zone branch would not have run. The latched target came back NULL, the unified set was failed at the latch, and tier exclusion failed the bridge set, so a touch in the top strip drove nothing at all. Resolve the dead-zone fallback in the target resolver as well, so the Tier-1 route has a driver, and keep the unified set's touch filter gesture-stable: a fresh resolve on the Touchdown (the only event whose dead-zone coordinate is meaningful) and the latched route afterwards, so a finger dragging out of the strip does not drop the widget mid-gesture. The fallback is now geometric on both sides: the sole widget captures a dead-zone touch only when its layer frame contains the Touchdown point. The dead zone exists for content that continues beneath the status bar; a widget positioned away from the strip has nothing under the touch and must not capture it. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/touch-nav-dead-zone-target
branch
from
August 19, 2026 21:04
07bdb46 to
11ffc15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — still validating on hardware.
Something else I noticed while experimenting with touch: on windows with a single registered widget (menu/scroll), any touch starting in the status-bar strip at the top of the screen did absolutely nothing — no scroll, no bridge buttons.
The router's dead-zone branch answers Tier-1 for the window's sole widget, but prv_resolve_widget_target only walks the active layer's parent chain, which by construction already failed (that's why the dead-zone branch ran). The latched target comes back NULL, the unified set is failed at the latch, and tier exclusion has already failed the bridge set — so both sets are dead and the touch drives nothing.
Two changes:
New tests: dead-zone Touchdown latches and drives an ops-bearing sole widget through a full pan, and a sole widget away from the strip drops. Full unit suite green.