Adding support for jwt token authorization authentication with a central Jwks - #131
Merged
dawid-nowak merged 7 commits intoSep 4, 2026
Conversation
dawid-nowak
commented
Sep 3, 2026
Contributor
- Enhanced support for AutzN/Z
- The verification keys are retrieved from centralized JWKS which needs to be configured at startup
- Isolation of claims and AuthorizedPrincipal. AuthorizedPrincipal is created based on the claims from the JWT token but it doesn't need to be. It should be used to isolate higher layers from the knowledge about the claims.
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
dawid-nowak
requested review from
cafalchio,
gandhipratik203,
lucarlig and
prakhar-singh1928
September 3, 2026 17:02
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
lucarlig
requested changes
Sep 4, 2026
Contributor
There was a problem hiding this comment.
Observed review and E2E outcomes:
- The expired-token test rejected before expiry validation because no verification keys were configured.
- The dataplane exited during startup because the E2E inputs did not provide the required JWKS/private-key configuration, so both external lanes remained at HTTP 502 and no MCP scenarios ran.
- Key selection and SaaS principal extraction do not preserve the required constraints and mappings.
lucarlig
reviewed
Sep 4, 2026
lucarlig
reviewed
Sep 4, 2026
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Contributor
|
/conformance |
lucarlig
reviewed
Sep 4, 2026
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
Concrete options for the open threads. The conformance topology would still need the self-hosted JWKS URL, the extractor would need a public re-export and injected constructor, and the HMAC fixtures would need RSA replacements if the algorithm policy is adopted.
dawid-nowak
force-pushed
the
dawid.nowak/adding_jwt_token_authorization_authentication
branch
from
September 4, 2026 12:00
95e24b5 to
4f3566a
Compare
lucarlig
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.