fix(graphile-schema): correlate SDL and _meta metadata to one schema build - #1561
Merged
Conversation
…ld boundary
Offline schema builds could pair one schema's SDL/introspection with another
schema's _meta metadata because callers read the process-global
_cachedTablesMeta after an awaited build. buildSchemaArtifacts() now returns
{ sdl, tablesMeta } derived from the same final executable GraphQLSchema
(via a schema-keyed WeakMap accessor), and buildSchemaSDL /
buildIntrospectionJSON / DatabaseSchemaSource.fetch are projections of it.
Fixes constructive-io/constructive-planning#1331
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The process-global metadata channel has no remaining consumers; remove cache.ts, the finalize mirror hook, and all re-exports instead of keeping a deprecated export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes constructive-io/constructive-planning#1331 — offline schema builds could return one schema's GraphQL artifacts paired with another schema's
_metametadata, because callers read the process-global_cachedTablesMetaas a separate operation after an awaited build (A write → B write → A read).The result now comes from one correlated build boundary keyed on the exact final executable
GraphQLSchema:_cachedTablesMetaand its plumbing (cache.ts, thefinalizemirror hook, all re-exports) are deleted outright — no deprecated compatibility export. Live_metabehavior is unchanged and staysWeakMap-scoped.tablesMetais an explicit[](never stale metadata from an unrelated build)._onMetaCollectedhook lets regression tests deterministically force the unsafeA write → B write → A readschedule (ordinaryPromise.allstress was shown to be too weak/flaky in the issue).Tests
graphile/graphile-schema/__tests__/build-schema-artifacts.test.ts(live PG): sequential, forced-interleave, uncoordinated-concurrent, and plugin-disabled cases — each caller gets only its own metadata.graphql/codegen/src/__tests__/introspect/database-source.test.ts(unit):DatabaseSchemaSource.fetch()returns introspection andtablesMetabelonging to the same schema even when another build completes mid-fetch.graphile/graphile-metaandgraphile/graphile-schemaare now run in thepg-graphqlbatch (previously only built).Link to Devin session: https://app.devin.ai/sessions/53231fe0747e4f0787814196eea57ee4
Requested by: @pyramation