Skip to content

Fix emscripten library linker warning #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcbarton wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix emscripten library linker warning #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
279f7ca
Apply -flto to all targets in Emscripten builds
mcbarton Nov 1, 2026
cbb9199
Temporarily turn on static library build for all Emscripten builds
mcbarton Nov 1, 2026
8cc176b
Update action.yml
mcbarton Nov 1, 2026
ad3862b
Revert back to original emscripten.yml
mcbarton Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/actions/Build_and_Test_CppInterOp/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,11 +505,7 @@ runs:
../
fi
os="${{ matrix.os }}"
if [[ "${os}" != macos* ]] ; then
EMCC_CORES=1 emmake ninja -j 1 check-cppinterop
else
emmake ninja -j ${{ env.ncpus }} check-cppinterop
fi
EMCC_CORES=1 emmake ninja -j 1 check-cppinterop
cd ./unittests/CppInterOp/
os="${{ matrix.os }}"
if [[ "${os}" == "macos"* ]]; then
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ option(CPPINTEROP_SHARED_LIBRARY_VERSIONING
set(CPPINTEROP_BAKED_INTERPRETER_ARGS "" CACHE STRING
"Space-separated arguments passed at interpreter creation (no quoting: arguments containing spaces are not supported)")
if(EMSCRIPTEN)
set(CPPINTEROP_LIBRARY_WASM_FLAGS "-Oz -flto" CACHE STRING "Extra flags for build of CppInterOp library")
set(CPPINTEROP_EXTRA_WASM_FLAGS "-fwasm-exceptions" CACHE STRING "Extra flags for wasm (all targets)")
set(CPPINTEROP_LIBRARY_WASM_FLAGS "-Oz" CACHE STRING "Extra flags for build of CppInterOp library")
set(CPPINTEROP_EXTRA_WASM_FLAGS "-fwasm-exceptions -flto" CACHE STRING "Extra flags for wasm (all targets)")
endif()

# Clad plugin options
Expand Down
Loading