Skip to content

Proposed fixes for the CWL JSON Schema - #312

Open
sim13pods wants to merge 3 commits into
common-workflow-language:codegenfrom
sim13pods:restore-pr-299
Open

sim13pods wants to merge 3 commits into
common-workflow-language:codegenfrom
sim13pods:restore-pr-299

Conversation

@sim13pods

Copy link
Copy Markdown

No description provided.

@mr-c
mr-c changed the base branch from main to codegen September 25, 2026 09:50
- updated schema to draft 2020-12;
- 'format: uuid' does not need the pattern to be specified;
- 'format: url' replaced with 'format: uri' that does not need pattern to be specified;
- single valued enums tranformed to constants;
- type: 'null' wrongly interpreted, replaced by 'type: null'
- fixed misaligned 'required' element in 'InlineJavascriptRequirement' entity.
@mr-c

mr-c commented Sep 25, 2026

Copy link
Copy Markdown
Member

@fmigneault do you approve these changes?

@mr-c mr-c changed the title Restore pr 299 Proposed fixes for the CWL JSON Schema Sep 25, 2026
@mr-c

mr-c commented Sep 25, 2026

Copy link
Copy Markdown
Member

(@sim13pods I moved this to the codegen branch because there is a CI test broken on main that I don't want to fix right now; when this PR is merged, I'll back-port this to main and fix the CI then)

@sim13pods

Copy link
Copy Markdown
Author

Thank you for the follow up @mr-c !!!

@fmigneault fmigneault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants