Skip to content

Backwards compatibility for misspelled method name #366

Open
yume02kki wants to merge 2 commits into
collabora:masterfrom
yume02kki:fix/charge-percent-typo
Open

Backwards compatibility for misspelled method name #366
yume02kki wants to merge 2 commits into
collabora:masterfrom
yume02kki:fix/charge-percent-typo

Conversation

@yume02kki

Copy link
Copy Markdown
Contributor

in response to #365

@yume02kki yume02kki changed the title Backwards compatibility for misspelt method name Backwards compatibility for misspelled method name Jul 10, 2026
@bl4ckb0ne

Copy link
Copy Markdown
Collaborator

Shouldn't libsurvive ship a deprecated alias for the old spelling?

In-order to not break stuff, Ive added an Alias for the old misspelled method name with a deprecated tag, Hope this helps :-)

Ideally no, IIRC a lot of downstream projects are just tracking master, I don't think having the typo'd and the fix version would be relevant.

I'd like to cut a release in a very near future, I'll have more time next week to take a look at the pending MRs before tagging something for consumers to track.

@Scrumplex

Scrumplex commented Jul 10, 2026

Copy link
Copy Markdown

Ideally no, IIRC a lot of downstream projects are just tracking master, I don't think having the typo'd and the fix version would be relevant.

Alpine as well as nixpkgs are currently tracking the most recent tag.

I have prepared a MR for monado to use the new function name, but I think CI will fail as it seems to be pulling in libsurvive from Alpine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants