Repository navigation
fix: preserve container subclass snapshots and cyclic references - #61
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounded snapshots currently turn common container subclasses into placeholders that lose their entries and fields. Capture dict/list/tuple/set/frozenset subclasses with builtin-compatible adapters that retain entries, original type names, instance attributes, slots, named fields, and shared references. Python 3.15 frozendict values use portable mapping copies.
Keep item/node selection bounded and avoid application hooks when reading types, entries, and attributes. OrderedDict retains link order for safe keys; custom-key order falls back to insertion order with a visible
mapping_orderomission. Preserve mutable cycles during pickle/dill state restoration, immutable-key lookup behavior, multiline pretty-printing, and snapshot metadata during recapture. Add targeted regressions and document the captured representation.Refs #58. Third PR in the series. PRs #59 and #60 are merged, and this PR now targets
main; the diff contains the container changes.Validation:
git diff --check, and strict Sphinx build passed.Native PID attachment on this local macOS/Python 3.15 interpreter remains blocked by OS permissions; this does not affect the passing CI matrix below.
CI on the latest head: all 10 checks passed, covering Linux Python 3.11–3.15, Windows/macOS Python 3.14, quality, documentation, and distributions. Workflow run.