feat(ENG-14033): add api key rule resource - #240
Open
daniellskelton wants to merge 4 commits into
Open
daniellskelton wants to merge 4 commits into
daniellskelton wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for managing Cloudsmith organization API key expiry rules via Terraform by introducing a new cloudsmith_api_key_rule resource and documenting its usage, alongside updating the generated API bindings dependency.
Changes:
- Added
cloudsmith_api_key_ruleTerraform resource (CRUD + import) backed by the Orgs API key rules endpoints. - Registered the new resource in the provider and added user-facing documentation.
- Bumped
github.com/cloudsmith-io/cloudsmith-api-gotov0.0.64.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Bumps cloudsmith-api-go to v0.0.64. |
| go.sum | Updates checksums for the cloudsmith-api-go version bump. |
| docs/resources/api_key_rule.md | Adds documentation and examples for cloudsmith_api_key_rule. |
| cloudsmith/resource_api_key_rule.go | Implements the new resource schema and CRUD/import behavior. |
| cloudsmith/provider.go | Registers cloudsmith_api_key_rule in the provider resources map. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
daniellskelton
marked this pull request as ready for review
September 9, 2026 14:29
cloudsmith-iduffy
approved these changes
Sep 9, 2026
mhutchings-182
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
cloudsmith_api_key_ruleresource, rules set a maximum permitted age for API keys belonging to an organization, per account type.Bumps cloudsmith-api-go to v0.0.64 for the generated bindings.
Type of Change
Testing
Manually verified against a local instance with dev_overrides: create, read, update, delete and import, plus a clean no-op plan after import.
Added acceptance tests