feat: property filter custom operator support#4579
Open
revezard wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds end-to-end support for custom operators in the Property Filter component. Consumers can define their own operator strings with custom matching logic, display descriptions, and accessible labels.
Key changes:
getAllowedOperatorsnow preserves custom operators (appended after known operators in standard display order)getAllowedFreeTextOperatorsupdated to handle extended operator objects and preserve custom operatorsoperatorToDescriptionchecks customdescriptionbefore built-in i18n, allowing consumers to override predefined operator labels (e.g.>described as "After" for date properties)matchOperatorrequires word boundary after text-based operators to prevent false matches (e.g. "in" not matching "internal")getOperatorDescriptionaccessor toInternalFilteringPropertyDepends on: cloudscape-design/collection-hooks#151
Related links, issue #, if available: n/a
How has this been tested?
operatorToDescription(custom description override, fallback to i18n, unknown operators)getAllowedOperators(custom operators preserved, ordering, duplicates)matchOperator(text-based operator word boundary, case-insensitive matching, symbolic operators unaffected)parseText(text-based operators with space, case-insensitive, no false match on value prefix)/#/light/property-filter/property-filter-custom-operatorexercising all scenariosReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.