feat: Table Column Groups Table#4482
Open
NathanZlion wants to merge 61 commits into
Open
Conversation
NathanZlion
changed the title
NathanZlion
force-pushed
the
dev-v3-natidere-table-group
branch
from
40c20ee to
84451af
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4482 +/- ##
==========================================
+ Coverage 97.43% 97.48% +0.05%
==========================================
Files 941 945 +4
Lines 29725 30127 +402
Branches 10804 10975 +171
==========================================
+ Hits 28962 29370 +408
+ Misses 716 710 -6
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NathanZlion
force-pushed
the
dev-v3-natidere-table-group
branch
from
84451af to
e9f4fd0
Compare
NathanZlion
force-pushed
the
dev-v3-natidere-table-group
branch
from
d6a98cb to
5cec8c8
Compare
NathanZlion
requested review from
georgylobko
and removed request for
a team and
georgylobko
NathanZlion
force-pushed
the
dev-v3-natidere-table-group
branch
from
8da3b07 to
227f21b
Compare
… isLastChildOfGroup prop
…/rowspan handling
…er, remove inline colgroup from sticky heder
…backwards compatibility
…lization" This reverts commit 9bdb50b.
pan-kot
reviewed
Jun 4, 2026
| const resizerBtn = splitGroupCell.find('button'); | ||
| if (resizerBtn) { | ||
| resizerBtn.fireEvent(new PointerEvent('pointerdown', { pointerType: 'mouse', button: 0, bubbles: true })); | ||
| document.body.dispatchEvent(new PointerEvent('pointerup', { pointerType: 'mouse', bubbles: true })); |
Member
There was a problem hiding this comment.
why is there no assertion for these actions?
| * which makes colspan headers automatically span the correct width. | ||
| * Must be rendered inside ColumnWidthsProvider. | ||
| */ | ||
| export function TableColGroup({ |
Member
There was a problem hiding this comment.
why do we define this component inside use-column-widths.tsx?
Member
Author
There was a problem hiding this comment.
It's existence is purely for width purpose mainly. Not sure where to put it, it was initially somewhere else. Moved it here for the sake of keeping it closer to why it's needed. I considered creating a separate file for it,but it's a very small component. I'm open to suggestions,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Table Column Grouping Feature support for Table Component.
Related links, issue AWSUI-9594, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.