fix(fortlogs): Add missing monitoring labels for PrometheusRules#1801
Merged
Conversation
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
ztomaszewska
force-pushed
the
feat/enable-opensearch-operator-metrics
branch
from
c051e72 to
fd5740b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenSearch extension/chart to ensure the generated PrometheusRule resources carry the same optional monitoring labels already supported for ServiceMonitors, enabling Prometheus rule discovery via label selectors.
Changes:
- Add
cluster.cluster.general.monitoring.labelstoPrometheusRule.metadata.labelsfor cluster/operator/guardian alert rules. - Bump OpenSearch plugin and Helm chart versions from
0.2.12to0.2.13.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
opensearch/chart/templates/alerts.yaml |
Adds optional monitoring labels to all rendered PrometheusRule resources. |
opensearch/chart/Chart.yaml |
Version bump to 0.2.13. |
opensearch/plugindefinition.yaml |
Keeps plugin and referenced chart version aligned at 0.2.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kuckkuck
approved these changes
Jul 8, 2026
ztomaszewska
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Add missing monitoring labels for PrometheusRules.