[audit-logs] merge chart with sapcc/helm-chart/system/audit-logs-otel#1759
Open
Kuckkuck wants to merge 5 commits into
Open
[audit-logs] merge chart with sapcc/helm-chart/system/audit-logs-otel#1759Kuckkuck wants to merge 5 commits into
Kuckkuck wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the OTEL-based audit-logs Helm chart setup into Greenhouse, introduces a vendored audit-poller subchart, and extends the collector configuration to ingest additional audit log sources and support OpenSearch/Kafka-style output flows.
Changes:
- Add
audit-polleras a vendored dependency (with its own templates/alerts/CI values). - Extend the audit-logs OpenTelemetryCollector config with new receivers/processors/pipelines (notably audit-poller log ingestion and additional containerd transforms).
- Expand
audit-logschart values to expose scheduling/rollout knobs (affinity, updateStrategy, podAnnotations, terminationGracePeriodSeconds) and add top-levelauditPollervalues.
Reviewed changes
Copilot reviewed 7 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| audit-logs/charts/vendor/audit-poller/Chart.yaml | Adds vendored audit-poller chart metadata. |
| audit-logs/charts/vendor/audit-poller/values.yaml | Adds default values for audit-poller. |
| audit-logs/charts/vendor/audit-poller/templates/configmap.yaml | Adds poller configuration ConfigMap (currently with a namespace templating issue). |
| audit-logs/charts/vendor/audit-poller/templates/deployment.yaml | Adds poller Deployment (imageTag handling can render invalid image). |
| audit-logs/charts/vendor/audit-poller/templates/secrets.yaml | Adds Secret for IAS credentials. |
| audit-logs/charts/vendor/audit-poller/templates/podmonitor.yaml | Adds PodMonitor (selector currently too broad for multi-release scenarios). |
| audit-logs/charts/vendor/audit-poller/templates/prometheus-alerts.yaml | Adds PrometheusRule including vendored alerts file. |
| audit-logs/charts/vendor/audit-poller/templates/pvc.yaml | Adds optional PVC. |
| audit-logs/charts/vendor/audit-poller/alerts/_ias-poller.alerts | Adds poller alert rules. |
| audit-logs/charts/vendor/audit-poller/ci/test-values.yaml | Adds CI values for subchart. |
| audit-logs/charts/Chart.yaml | Adds the audit-poller dependency (alias auditPoller) behind auditPoller.enabled. |
| audit-logs/charts/values.yaml | Adds new collector knobs + auditPoller values; modifies OpenSearch failover values (currently inconsistent/missing). |
| audit-logs/charts/templates/audit-logs-collector.yaml | Adds audit-poller receiver/processor/pipeline wiring; expands containerd transform chain; changes failover inclusion behavior; adds new spec knobs. |
| audit-logs/charts/templates/_auditpoller-config.tpl | New audit-poller receiver/processor/pipeline snippets for the collector. |
| audit-logs/charts/templates/_auditd-config.tpl | Updates auditd rules (PCI-DSS keyed rules). |
| audit-logs/charts/templates/secret.yaml | Removes conditional around failover B credentials (currently fails templating with default/null values). |
| audit-logs/charts/ci/test-values.yaml | Removes audit-logs CI test values file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c62dc2f to
8148bb3
Compare
joluc
requested changes
Jul 7, 2026
Signed-off-by: I504010 <timo.johner@sap.com>
joluc
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge the
sapcc/helm-charts/system/audit-logs-otelchart into the Greenhouseaudit-logsplugin as a single source for OTEL-based audit log collection.Changes
Architecture
forwardconnector withroutingconnector (default_pipelines+ emptytable) for future content-based routing without pipeline restructuringfailover.enabledtoggle)logsCollector.kafka.enabled)Collector
hostPID/privilegedonly whenauditd.enabled)podAnnotations,affinity,terminationGracePeriodSecondsAudit-Poller Subchart
audit-pollersubchart with deployment, configmap, secrets, PVC, PodMonitor, and PrometheusRuleauditPoller.*) is single source of truth for all configurationauditPoller.image.repository/auditPoller.image.tagauditPoller.playbook.basePath).Files.Get)global.*values (prometheus,region,clusterType,cluster) propagated to subchartBug Fixes
lifesavercondition: use dotted-keyotel.scope.nameinstead of nested map accesslogs/k8seventspipeline{{ .Release.Namespace }}instead of undefined.Values.namespace.Values.image.repository/.Values.image.tagCleanup
_audit-config.tpl(defined but never included)updateStrategy(OTel Operator default applies)scheduling-values.yamlCI test