refactor(opensearch): set snapshot-lifecycle clusterHost default#1739
Open
joluc wants to merge 1 commit into
Open
refactor(opensearch): set snapshot-lifecycle clusterHost default#1739joluc wants to merge 1 commit into
joluc wants to merge 1 commit into
Conversation
…in template Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the OpenSearch Helm chart’s snapshot-lifecycle clusterHost default so it is computed in the manifest (template) instead of being a templated string in values.yaml, and bumps the chart/plugin versions accordingly.
Changes:
- Move the default
cluster.snapshotLifecycle.clusterHostcomputation fromvalues.yamlintotemplates/snapshot-lifecycle.yaml. - Update documentation to reflect
clusterHost: ""meaning “use in-cluster service default”. - Bump OpenSearch chart and PluginDefinition versions from
0.2.4to0.2.6.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| opensearch/README.md | Updates value documentation for cluster.snapshotLifecycle.clusterHost default/behavior. |
| opensearch/plugindefinition.yaml | Bumps PluginDefinition and referenced chart version to 0.2.6. |
| opensearch/chart/values.yaml | Changes cluster.snapshotLifecycle.clusterHost default to empty string and updates comments. |
| opensearch/chart/templates/snapshot-lifecycle.yaml | Computes default in template and wires CLUSTER_HOST env var from computed value. |
| opensearch/chart/Chart.yaml | Bumps chart version to 0.2.6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
27
to
+28
| - name: CLUSTER_HOST | ||
| value: {{ tpl $cfg.clusterHost .root | quote }} | ||
| value: {{ .clusterHost | quote }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
move clusterHost go template from values.yaml to manifest