Skip to content

Add missing storage-cli S3 config parameters to blobstore templates#673

Merged
kathap merged 1 commit into
developfrom
add-single-upload-threshold-s3-param
Jul 16, 2026
Merged

Add missing storage-cli S3 config parameters to blobstore templates#673
kathap merged 1 commit into
developfrom
add-single-upload-threshold-s3-param

Conversation

@kathap

@kathap kathap commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Add missing storage-cli S3 config parameters to blobstore templates:

  • A short explanation of the proposed change:
    Add missing storage-cli S3 config parameters (single_upload_threshold, request_checksum_calculation_enabled, response_checksum_calculation_enabled, uploader_request_checksum_calculation_enabled) to all blobstore JSON templates across all 5 jobs and 4 resource types.
  • An explanation of the use cases your change solves
    These fields allows operators to:
    • Control whether files are uploaded via a single PutObject call or multipart upload (single_upload_threshold)
    • Disable checksum calculation/validation for S3-compatible providers that do not support it (e.g. AliCloud)

All parameters are optional. If not set in the manifest, the key is omitted from the generated JSON and storage-cli applies its own defaults:

  • single_upload_threshold: 0 (always use multipart upload)
  • request_checksum_calculation_enabled: true
  • response_checksum_calculation_enabled: true
  • uploader_request_checksum_calculation_enabled: true

@kathap
kathap merged commit 237f67e into develop Jul 16, 2026
3 checks passed
@moleske
moleske deleted the add-single-upload-threshold-s3-param branch July 16, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants