Skip to content

chore(ui): Gate <ConfigureSSO /> based on organization system permission#8515

Merged
LauraBeatris merged 6 commits into
mainfrom
laura/handle-org-permission
May 11, 2026
Merged

chore(ui): Gate <ConfigureSSO /> based on organization system permission#8515
LauraBeatris merged 6 commits into
mainfrom
laura/handle-org-permission

Conversation

@LauraBeatris
Copy link
Copy Markdown
Member

@LauraBeatris LauraBeatris commented May 8, 2026

Description

Check against current user session, if it's outside of a personal workspace and doesn't have the system permission to manage enterprise connection.

CleanShot 2026-05-11 at 17 33 06

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 11, 2026 8:33pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: 0ba775c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/ui Patch
@clerk/react Patch
@clerk/chrome-extension Patch
@clerk/expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris self-assigned this May 8, 2026
@LauraBeatris LauraBeatris requested review from a team and iagodahlem May 8, 2026 19:22
@LauraBeatris LauraBeatris force-pushed the laura/handle-org-permission branch from ed2e5fc to 51e28cf Compare May 8, 2026 19:26
@LauraBeatris LauraBeatris marked this pull request as ready for review May 8, 2026 19:27
@LauraBeatris LauraBeatris force-pushed the laura/handle-org-permission branch from 1f749b7 to aac0891 Compare May 8, 2026 19:58
@iagodahlem iagodahlem force-pushed the iago/configure-sso-layers branch from 7dc3f44 to 94f83bd Compare May 11, 2026 13:34
@LauraBeatris LauraBeatris marked this pull request as draft May 11, 2026 15:37
Base automatically changed from iago/configure-sso-layers to main May 11, 2026 15:39
@LauraBeatris LauraBeatris force-pushed the laura/handle-org-permission branch from f075386 to 3110ac8 Compare May 11, 2026 15:46
@LauraBeatris LauraBeatris marked this pull request as ready for review May 11, 2026 15:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 95c1a635-eef0-4fd5-b4cc-7d2c9b25b3a7

📥 Commits

Reviewing files that changed from the base of the PR and between 4695a65 and 0ba775c.

📒 Files selected for processing (2)
  • packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx
  • packages/ui/src/components/ConfigureSSO/elements/ProfileCard.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/ui/src/components/ConfigureSSO/elements/ProfileCard.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx

📝 Walkthrough

Walkthrough

This PR implements permission-based access control for the ConfigureSSO component when used in organizational contexts. It adds a system permission check (org:sys_enterprise_connections:manage) that gates access to enterprise connection management and displays a permission-denied message in 47 languages when the user lacks authorization. The change includes type definitions, multi-language localization strings, component-level permission checking logic with a dedicated UI fallback, and test coverage validating behavior across organizational and personal workspace scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • clerk/javascript#8427: Adds experimental ConfigureSSO component scaffolding that this PR builds upon with permission gating and multi-language support.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: gating the ConfigureSSO component based on organization system permission, which aligns with the core functionality addition in the PR.
Description check ✅ Passed The description is related to the changeset, explaining the permission check logic against user session and organization workspace context, with a visual demonstration of the permission error state.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 11, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8515

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8515

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8515

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8515

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8515

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8515

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8515

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8515

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8515

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8515

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8515

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8515

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8515

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8515

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8515

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8515

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8515

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8515

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8515

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8515

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8515

commit: 0ba775c

Comment thread packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx Outdated
Comment thread packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx Outdated
Comment thread packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx Outdated
Comment thread packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx Outdated
Comment thread packages/ui/src/components/ConfigureSSO/ConfigureSSO.tsx Outdated
@LauraBeatris LauraBeatris enabled auto-merge (squash) May 11, 2026 20:37
@LauraBeatris LauraBeatris merged commit 1084180 into main May 11, 2026
45 checks passed
@LauraBeatris LauraBeatris deleted the laura/handle-org-permission branch May 11, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants