Repository navigation
Migrate to TanStack Start RC - #5
Merged
Merged
Conversation
Comment on lines
16
to
19
| declare module '@tanstack/react-router' { | ||
| interface Register { | ||
| router: ReturnType<typeof createRouter> | ||
| router: ReturnType<typeof getRouter> | ||
| } |
Contributor
There was a problem hiding this comment.
Not sure if it matters, but this isn't present when creating a new Tanstack app.
| <SignedOut> | ||
| <p>You are signed out</p> | ||
| <SignInButton /> | ||
| <SignInButton mode="modal" /> |
Contributor
There was a problem hiding this comment.
This isn't in the quickstart changes from this PR: clerk/clerk-docs#2690
SarahSoutoul
requested changes
Oct 14, 2025
SarahSoutoul
left a comment
SarahSoutoul
left a comment
Contributor
There was a problem hiding this comment.
Left some comments! LGTM overall. Think we should update the Introduction on the README too, as it mentions the old createClerkHandler stuff.
wobsoriano
marked this pull request as ready for review
October 14, 2025 20:56
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.