fix(server/state): ignore stale frame acknowledgements - #4063
Open
ThomasAlvenin wants to merge 1 commit into
Open
fix(server/state): ignore stale frame acknowledgements#4063ThomasAlvenin wants to merge 1 commit into
ThomasAlvenin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Avoid creating an empty client frame state when an acknowledgement arrives after its frame has already been removed.
How is this PR achieving the goal
frameStates[frameIndex]inserts a defaultClientEntityStatewhen the ACK is for a frame that is no longer tracked.Using
find()lets us ignore those late ACKs without mutating the map. Existing frames still follow the same ACK path as before :pThis PR applies to the following area(s)
Server
Successfully tested on
Game builds: 3258
Platforms: Windows
Verified by replaying an ACK after its frame had already been removed.
Checklist
Fixes issues
No linked issue.