Skip to content

test(transfers): use a destination entity in the sandbox platform - #693

Merged
armando-rodriguez-cko merged 1 commit into
masterfrom
fix/transfers-it-sandbox-destination
Oct 15, 2026
Merged

armando-rodriguez-cko merged 1 commit into
masterfrom
fix/transfers-it-sandbox-destination

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
The transfers integration tests sent funds to ent_w4jelhppmfiufdnatam37wrfc4, the example entity from the public documentation, which is not part of the sandbox test platform. The sandbox now validates the destination and answers 422 destination_entity_out_of_scope, so these tests fail on every branch. This PR points them at a sub-entity of the test platform and lowers the amount to the minimum (1).

Changes

  • Transfers integration test: destination ent_ocw5i74vowfg2edpy66izhts2u (a sub-entity of the source's own platform), amount 1 instead of 100/200, and the matching amount assertions.

API Reference

Breaking changes
None. Test-only change.

README
No change needed.

@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team October 14, 2026 13:59
@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • 2.2.4_test_only

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
2.2.4_test_only classifying §2.2.4 Every file matches a test-file pattern.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

The documentation example entity is outside the sandbox test platform; the
sandbox now rejects it with destination_entity_out_of_scope. Amount lowered
to 1.
@armando-rodriguez-cko
armando-rodriguez-cko force-pushed the fix/transfers-it-sandbox-destination branch from 75a2e74 to ca7b5da Compare October 15, 2026 12:57
@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • 2.2.4_test_only

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
2.2.4_test_only classifying §2.2.4 Every file matches a test-file pattern.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • 2.2.4_test_only

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • 2.2.4_test_only

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
2.2.4_test_only classifying §2.2.4 Every file matches a test-file pattern.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@armando-rodriguez-cko
armando-rodriguez-cko merged commit c602f16 into master Oct 15, 2026
8 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the fix/transfers-it-sandbox-destination branch October 15, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants