Skip to content

fix(setups): send pay by bank under the paybybank key - #692

Merged
armando-rodriguez-cko merged 1 commit into
masterfrom
fix/INT-1717-paybybank-key
Oct 15, 2026
Merged

armando-rodriguez-cko merged 1 commit into
masterfrom
fix/INT-1717-paybybank-key

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
The Payment Setup API names the Pay by Bank method paybybank. This SDK sent it as pay_by_bank, which the API ignores without an error, so Pay by Bank configuration was silently dropped. This PR sends the correct key and adds the risk object (enabled).

Changes

  • PaymentMethods.java: @SerializedName("paybybank") on payByBank (the field name is unchanged)
  • entities/risk/PaymentSetupRisk.java (new): Boolean enabled
  • PaymentSetupsRequest.java, PaymentSetupsResponse.java: risk added
  • PaymentSetupsPayByBankSerializationTest.java (new) and PaymentSetupsNewFieldsSerializationTest.java: literal key, response action, risk roundtrip and swagger example

API Reference

Breaking changes
None. The public member is unchanged; only the wire key is fixed.

README
No change needed.

@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team October 14, 2026 10:27
@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR fixes a serialization key name, adds a new simple data-only class with one Boolean field, and wires it into existing request/response DTOs — all non-destructive, no new endpoints, no auth/authz, no persistence, no external integrations, and fully within existing abstractions.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 6


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The PR fixes a serialization key name, adds a new simple data-only class with one Boolean field, and wires it into existing request/response DTOs — all non-destructive, no new endpoints, no auth/authz, no persistence, no external integrations, and fully within existing abstractions. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change fixes a serialization key name, adds a simple new data-only class (PaymentSetupRisk) with no persistence or auth implications, and extends existing request/response POJOs with an optional field, all within existing endpoints and abstractions without introducing new integrations or background processes.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 6


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change fixes a serialization key name, adds a simple new data-only class (PaymentSetupRisk) with no persistence or auth implications, and extends existing request/response POJOs with an optional field, all within existing endpoints and abstractions without introducing new integrations or background processes. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

The Payment Setup API names the Pay by Bank method paybybank; the old key
is ignored without an error. Also adds the risk object (enabled).
@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR only fixes a serialization key annotation, adds a simple new data-only class with one Boolean field, and wires it into existing request/response objects — all non-destructive, function-preserving extensions of existing abstractions with no new endpoints, auth changes, persisted data, or external integrations.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 6


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The PR only fixes a serialization key annotation, adds a simple new data-only class with one Boolean field, and wires it into existing request/response objects — all non-destructive, function-preserving extensions of existing abstractions with no new endpoints, auth changes, persisted data, or external integrations. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change fixes a serialized wire key on an existing field, adds a simple new optional field to existing request/response DTOs using an existing abstraction pattern, introduces no new endpoints or external integrations, persists no new data, and crosses no trust boundary.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@armando-rodriguez-cko
armando-rodriguez-cko merged commit a63fac1 into master Oct 15, 2026
6 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the fix/INT-1717-paybybank-key branch October 15, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants