Repository navigation
fix(setups): send pay by bank under the paybybank key - #692
Conversation
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 6 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
4418bb5 to
45cd9bf
Compare
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 6 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
The Payment Setup API names the Pay by Bank method paybybank; the old key is ignored without an error. Also adds the risk object (enabled).
45cd9bf to
c6f1dab
Compare
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 6 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The change fixes a serialized wire key on an existing field, adds a simple new optional field to existing request/response DTOs using an existing abstraction pattern, introduces no new endpoints or external integrations, persists no new data, and crosses no trust boundary.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…



Summary
The Payment Setup API names the Pay by Bank method
paybybank. This SDK sent it aspay_by_bank, which the API ignores without an error, so Pay by Bank configuration was silently dropped. This PR sends the correct key and adds theriskobject (enabled).Changes
PaymentMethods.java:@SerializedName("paybybank")onpayByBank(the field name is unchanged)entities/risk/PaymentSetupRisk.java(new):Boolean enabledPaymentSetupsRequest.java,PaymentSetupsResponse.java:riskaddedPaymentSetupsPayByBankSerializationTest.java(new) andPaymentSetupsNewFieldsSerializationTest.java: literal key, responseaction,riskroundtrip and swagger exampleAPI Reference
POST /payments/setups: payment_methods.paybybank, riskPUT /payments/setups/{id}: payment_methods.paybybank, riskGET /payments/setups/{id}Breaking changes
None. The public member is unchanged; only the wire key is fixed.
README
No change needed.