Skip to content

test: reword test comments that pointed at internal files #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armando-rodriguez-cko merged 1 commit into from
Oct 8, 2026
Merged

test: reword test comments that pointed at internal files #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/test/java/com/checkout/balances/BalancesSerializationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* <p>Covers the top-up instructions response
* (GET /entities/{entityId}/currency-accounts/{currencyAccountId}/top-up-instructions) and the
* entity balances response (GET /balances/{id}). Every value is taken from the field-level
* {@code example} values in shared/swagger-latest.json; neither response schema carries a
* {@code example} values in the API reference; neither response schema carries a
* top-level example.
*
* <p>The spec is explicit that neither funding rail is guaranteed: TopUpBankDetails declares no
Expand Down Expand Up @@ -273,9 +273,8 @@ void shouldOmitUnsetOptionalFundingFields() {
// ------------------------------------------------------------------------
// BalancesResponse / CurrencyAccountBalance / Balances / CollateralBreakdown
//
// Added when Balance.operational was found missing from the SDK during the INT-1692 review;
// review-integrity.mdc section 9 requires a serialization test for a new field on an
// existing class.
// Covers every property, including Balance.operational, so a field missing from the model
// fails here instead of being silently dropped.
// ------------------------------------------------------------------------

@Test
Expand Down
Loading