Branch Protection Not Recognized by Kodiak

[lodmfjord]

We have encountered an issue where Kodiak does not recognize the branch protection rules applied to our release/30.1.0 branch. Specifically, even though we have branch protection enabled, Kodiak is behaving as if there are no such rules in place.

Possible Cause:
This issue might be due to a limitation in the GitHub API. Our repository currently has 101 branches with this specific protection rule. Does the API only return the first 100 hits?

Workaround 1:
Creating a new protection rule for this branch works.

Workaround 2:
Deleting one branch worked - 100 branches are then branch protected by this rule.

Additional Context:
Link to a pull request

[chdsbd]

This looks like a bug. We select the first 100 branch protection rules here:

kodiak/bot/kodiak/queries/__init__.py

Line 159 in 0065e64

branchProtectionRules(first: 100) {

[chdsbd]

The issue in this query is the matchingRefs call:

kodiak/bot/kodiak/queries/__init__.py

Lines 161 to 165 in ba50732

	matchingRefs(first: 100) {
	nodes {
	name
	}
	}

[chdsbd]

If you use rulesets instead of branch protection rules you shouldn’t have this issue