Reviewer cleanups for #2667: single enablement flag, drop unused NAME, assertNull - #3
Closed
Buktal wants to merge 1 commit into
Closed
Conversation
- extract a single artifactDeliveryEnabled boolean shared by the workspace prompt flag and the deliver_artifact registration so the two cannot drift - drop the unused ArtifactDeliveryTool.NAME constant (annotation, middleware and tests all use the literal) - use assertNull instead of assertEquals(null, ...) in the tool test
Author
|
That PR was my mistake — the commit has been pushed directly to the PR branch instead (see agentscope-ai#2667, now includes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-ups from review of agentscope-ai#2667 — merging this into
fix/artifact-delivery-toolfolds them into that PR:artifactDeliveryEnabledboolean shared by the workspace-prompt flag and thedeliver_artifactregistration so the two cannot driftArtifactDeliveryTool.NAMEconstant (annotation, middleware and tests all use the literal)assertNullinstead ofassertEquals(null, ...)in the tool testVerified: full
agentscope-harnessmodule test suite green andspotless:checkclean.