The LiveView connection banners say Reconnecting (T-468) - #336
Closed
chasers wants to merge 1 commit into
Closed
Conversation
…went wrong (T-468) When a tab sleeps and its socket rejoins, the layout showed Phoenix's generated flashes — "Something went wrong!" for the server-error case and "We can't find the internet" for the client-error one — for what is an ordinary reconnect. Both are titled Reconnecting now, each with a line saying the page picks up again on its own; the spinner and the show/hide wiring on phx-disconnected and phx-connected are unchanged. A layouts test renders the flash group and pins the wording. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NBmgYoYciJzbcxNYA9Z4d6
Owner
Author
|
Closing: the wording change papers over a reconnect fault we want to root-cause first (T-468). Keeping the branch until the diagnosis lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker: T-468.
After a tab sleeps, the LiveView layout showed Phoenix's generated "Something went wrong!" (server-error) or "We can't find the internet" (client-error) flash while the socket rejoined. Both banners are now titled Reconnecting, each with one line saying the page picks up again on its own. The spinner and the
phx-disconnected/phx-connectedshow-hide wiring are unchanged. A new layouts test renders the flash group and pins the wording.mix precommit,mix ciandmix dialyzergreen.🤖 Generated with Claude Code
https://claude.ai/code/session_01NBmgYoYciJzbcxNYA9Z4d6