Skip to content

ci: run sobelow on the lint leg - #129

Merged
barrieloydall merged 2 commits into
mainfrom
bloydall/ci-sobelow
Nov 8, 2026
Merged

barrieloydall merged 2 commits into
mainfrom
bloydall/ci-sobelow

Conversation

@barrieloydall

@barrieloydall barrieloydall commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Runs mix sobelow --exit --config on the lint leg (Elixir 1.20 / OTP 29), after credo.
  • Sets exit: false in .sobelow-conf. Sobelow rejects the string "false" (Invalid --exit: "false") whenever --exit isn't passed on the command line, so mix sobelow --config failed.

Why

The sobelow dependency and .sobelow-conf were already in the repo, but CI never ran it, so new findings went unnoticed.

Reviewer Notes

  • main has 0 findings locally.
  • --exit overrides exit: "false" in .sobelow-conf, so any finding fails the job.

Test Plan

  • Check the Elixir 1.20 / OTP 29 job passes and shows the "Run sobelow" step.

🤖 Generated with Claude Code

Sobelow and .sobelow-conf were already set up but never ran in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@barrieloydall
barrieloydall marked this pull request as ready for review November 8, 2026 07:59
@barrieloydall
barrieloydall requested a review from a team as a code owner November 8, 2026 07:59
Sobelow rejects exit: "false" when --exit isn't passed on the command line
(Invalid --exit: "false"), so running mix sobelow --config failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@barrieloydall
barrieloydall merged commit 964f404 into main Nov 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant