Fix llama-cpp-python version detection and run-all.bat nested-quote start commands#8
Open
chainchopper with Copilot wants to merge 2 commits into
Open
Fix llama-cpp-python version detection and run-all.bat nested-quote start commands#8chainchopper with Copilot wants to merge 2 commits into
chainchopper with Copilot wants to merge 2 commits into
Conversation
…ested-quote start commands Co-authored-by: chainchopper <36168576+chainchopper@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with Windows batch setup scripts
Fix llama-cpp-python version detection and run-all.bat nested-quote start commands
Mar 3, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes two Windows batch-script issues affecting optional llama-cpp-python installation and launching backend/frontend services on paths containing spaces.
Changes:
- Fixes Python minor-version detection in
setup.batso the correctllama-cpp-pythonwheel branch is taken. - Fixes
run-all.batstart ... cmd /kinvocations by delegating torun-backend.bat/run-frontend.bat(avoids broken nested quoting). - Updates
setup.bat’srun-all.batgeneration block to emit the corrected launch commands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.bat | Corrects Python minor version parsing and updates generated run-all.bat launch lines to avoid nested-quote issues. |
| run-all.bat | Replaces inline cmd /k "call ... & ..." with calls to run-backend.bat / run-frontend.bat for robust launching on Windows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 3, 2026
Draft
Copilot AI
added a commit
that referenced
this pull request
Mar 3, 2026
…ation - run-all.bat: Replace broken nested-quote START commands with clean delegation to run-backend.bat / run-frontend.bat helper scripts - setup.bat: Fix generated run-all.bat lines to use ^!ROOT^!\run-backend.bat and ^!ROOT^!\run-frontend.bat with proper caret-escaped vars - backend/Dockerfile: Add cmake, migrate llama.cpp build from make to CMake, update COPY paths to build/bin/ to match CMake output layout Supersedes conflicting PRs #8, #9, #10, #11, #12 Co-authored-by: chainchopper <36168576+chainchopper@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two broken Windows batch script paths: the optional llama-cpp-python install always fell through to the wrong branch, and run-all.bat's
cmd /kinvocations were structurally malformed.setup.bat— llama-cpp-python version detection (tokens=2→tokens=1)platform.python_version_tuple()[1]emits a single token (11,12).tokens=2never matched, leavingPY_MINORunset — both version branches were skipped and the fallback--only-binary :all:(which has no cu130 wheels) always ran.run-all.bat— nested double-quotes incmd /kargumentscmd /k "call "path\activate.bat" & …"has unescaped inner quotes; cmd.exe closes the string at the first inner"so the activate step is truncated and silently broken on any path with spaces.Delegates to the already-committed
run-backend.bat/run-frontend.bat, eliminating the nesting entirely.setup.bat— run-all.bat generation block updated to matchThe fallback echo lines that write the
startcommands (only triggered when run-all.bat is absent) had the same nested-quote bug. Updated to emit the same clean pattern;^!ROOT^!escaping ensures the generated file receives a literal!ROOT!variable reference rather than a hardcoded path baked in at generation time.Original prompt
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.