Report fallback auth-tx failures under a calldata-typed txRef#469
Merged
piersy merged 1 commit intoJul 9, 2026
Merged
Conversation
…xRef The auth tx of a fallback pair was submitted and its failures forwarded under the batch txdata's txRef. With a blob batch, an auth-tx failure surfaced with isBlob=true, so an ErrAlreadyReserved failure (account reserved by a stuck blob tx, e.g. left in the blobpool across a restart) made cancelBlockingTx send a calldata cancel against a blobpool reservation. That cancel is rejected the same way, the txpool state resets to good on its receipt, and the cycle repeats: the blob cancel needed to replace the stuck tx is never sent and no batch ever lands. Derive a calldata-typed authReference for the auth tx's queue.Send and its failure receipts, keeping the batch txdata's id so failures still requeue the right frames. Claude-Session: https://claude.ai/code/session_013uE8M5ZPGXWTdhpeqmL5g3
piersy
force-pushed
the
espresso/batcher-fallback-auth-txref
branch
from
8abf21c to
882b8ca
Compare
piersy
changed the base branch from
espresso/batcher-fallback
to
espresso/batcher-fallback-audit-m3
lukeiannucci
approved these changes
Jul 9, 2026
lukeiannucci
left a comment
lukeiannucci
left a comment
Collaborator
There was a problem hiding this comment.
Nice, I see the comment by codex which i missed earlier
#458 (comment)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 882b8ca8e8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a txpool-recovery livelock found while reviewing this branch. The bug predates #467 but the fix lands on the rewritten synchronous function.
The auth tx is always calldata, but its failure receipts are forwarded under the batch txdata's txRef, so with blob batches an auth failure is labeled as a blob failure. That matters for ErrAlreadyReserved: geth refuses a tx at submission when a tx of the other type from the same account is still in the pool, so a blob batch tx left in the blobpool across a restart makes the first auth tx bounce. The recovery in cancelBlockingTx infers the stuck tx's type from the failed tx's type and sends a cancel of the stuck type to replace it in its own pool. Fed the wrong label, it sends a calldata cancel, which the same blobpool reservation rejects; the txpool state then resets to good on the cancel's receipt and the next auth tx starts the cycle again. The blob cancel that would replace the stuck tx is never sent, so the batcher spins without landing batches until an operator intervenes.
The fix derives a calldata-typed authReference used for the auth tx's queue.Send and its failure receipts, keeping the batch txdata's id so a failed pair still requeues the right frames. Batch failures, the window check and the success receipt keep the batch ref, which is where the daType and size metrics read from.
https://claude.ai/code/session_013uE8M5ZPGXWTdhpeqmL5g3