Repository navigation
fix: fix hax compilation of libcrux-hmac - #1642
Conversation
|
Thanks for filing! Would it resolve your issue if we |
|
Ah thank you! Regrettably i only compiled with code with cfg hax and didn't run extraction, and now see that that was an issue.
That would also work. Do you have a preference on me excluding the length constants too? If so I'll remove the macro and add excludes in impl_digest_trait |
|
No worries! |
3c3da3c to
13dbaf1
Compare
Signed-off-by: asra <asra@freedom.press> exclude the trait implementations from extraction Signed-off-by: asra <asra@freedom.press>
13dbaf1 to
7f24600
Compare
|
Rebased & updated! |
|
Awesome, thanks! If we could have a patch release for the hmac crate when convenient that would be great! And to prevent our proof validation in the future, would it be possible to add hax extract / prove CI check for the hmac crate too? I can give it a stab |
Fixes #1641
This fixes the hax configuration build for hmac by exporting the sha3 types
[skip changelog]