Nicer errors on "evaluate" with syntax errors in context/entities - #17
Merged
Merged
Conversation
Signed-off-by: John Kastner <jkastner@amazon.com>
There was a problem hiding this comment.
Pull request overview
Improves the Policy Playground “Evaluate” flow by surfacing a clear UI error when context or entities contain invalid JSON (instead of deferring to WASM error output), and adds regression tests covering both invalid-input cases.
Changes:
- Add explicit JSON parsing with early-return error output for
entitiesandcontextinevaluateInput. - Add sandbox tests that load invalid
entities/contextvia URL hash and assert the improved error message is shown.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/routes/policy-playground/PolicyPlayground.tsx |
Adds explicit JSON parse error handling for entities and context before invoking isAuthorized. |
tests/sandbox.test.tsx |
Adds tests that verify the UI displays the “Invalid context or entities input” message for invalid JSON in entities and context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Swolebrain
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fall-through to WASM errors didn't given useful error messages. By treating an invalid context as empty we would get some unrelated validation error complaining about missing attributes, or it could even proceed to authorization if the action accepted an empty context.
For invalid JSON in the context:
old:
new: