cypress tests + workflow - #14
Merged
Merged
Conversation
john-h-kastner-aws
previously approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
How do pre-commit hooks work with husky? I generally just find them annoying, but if it's opt-in to enable this is fine
Contributor
Author
There was a problem hiding this comment.
The precommit hook itself is not meant to be opt-in but running the cypress tests is. Linting this and running unit tests takes about 8 seconds. Cypress tests take much longer, so those are optional. the husky hook will ask you if you want to run them.
john-h-kastner-aws
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some very basic cypress tests. To get them to work i had to get rid of webpack vendor code chunk splitting. I think this is fine.