Change HTTP method strings to uppercase - #273
Open
fitudao3788 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the HTTPApi request method strings to use uppercase HTTP verbs to avoid connection failures observed on Windows 11 + Python 3.10 when using urllib.request with lowercase method names.
Changes:
- Change
post()to call_request(..., method="POST")instead of"post". - Change
_request()default method from"get"to"GET".
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I fixed an issue observed on Windows 11 and Python 3.10 where connecting to the CDP using
urllib.requestwith a lowercase method name resulted in a "Failed to connect to browser" error, preventing access.Pre-merge Checklist
./scripts/format.shand./scripts/lint.shscripts. My code is properly formatted and has no linting errors.uv run pytestand ensured all tests pass.[Unreleased]section.