feat!: compatibility with matplotlib 3.11 - #128
Conversation
|
@brambozz any chance you could give this a review? you know it better than i do i think :) |
|
Yes, I will try to have a look this week! |
|
@miloth Thanks for the comprehensive PR, overall looks good to me! Especially really like the addition of a default (non-mono) colormap! That makes a lot of sense, and is something I could have used for a while. Only thing I am not a fan of is the removal of the Original: PR suggestion: @backwardspy:I think it would be good if you have a quick look too, as there are some changes to files I did not write (e.g. build.py). But looks good to me! One specific thing I spotted:
|
|
Hi @brambozz, please find the replies below:
|
|
@miloth Thanks for the update! You have me convinced, it is probably indeed cleaner and more appropriate here to keep the API minimal. Also the reasoning for the versioning is fine with me, but still something I would like to give @backwardspy the final word on. So @backwardspy: For me it's all good now! But my earlier suggestion of you having a quick look still stands :) |
Matplotlib 3.11 reworked the style module, changing the APIs that were used here. This aims at solving that and a bit more:
"catppuccin.<flavor>".catppuccin.extras.matplotlibmodule. Their functionality can be replicated with a one liner of Matplotlib's APIs. All the examples now use these one liners.cmaps as well.cmaps to be colored and not mono.