3.1.0: slim default request context#190
Closed
bartes wants to merge 1 commit into
Closed
Conversation
bartes
force-pushed
the
chore/modernize-sdk
branch
from
ab93042 to
376663f
Compare
The default request context no longer derives client_id: it is already carried by the request headers and resolved server-side, so computing it in the SDK is redundant. Remove the internal client-id extraction service and the now-unused cookie plumbing (HeadersGetCookieService).
bartes
force-pushed
the
chore/3.1-slim-context
branch
from
0432ae9 to
a0260c0
Compare
bartes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A
3.1.0follow-up that slims the default request context. The default context no longer derivesclient_id: it is already carried by the request headers and resolved server-side, so computing it in the SDK is redundant.Stacked on the
chore/modernize-sdk(3.0.0) branch — review/merge that first.Changes
ContextGetDefaultServicenow returns onlyheaders,ipandlibrary.src/client-id/) and the now-unused cookie plumbing (HeadersGetCookieService), along with their tests.3.1.0and add the changelog entry.