feat: add segmented control component - #1401
Conversation
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Quite a few concerns and thoughts on the proposed component can be found below.
|
@edlerd thank you for your review, I'll take a look at the proposed changes and update the PR. |
|
@edlerd made the changes, can you please check ? |
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Thanks for the adjustments. Nearly perfect, just one question left below then it can be merged from my side.
Also, can you please rebase on main to get the latest changes in?
|
@edlerd removed the tabIndex |
* remove datatest-id from components * add id to button * add proper key to button * replace datatest-id in tabpanel with aria-labelleby attribute * remove unncessary props * change segmentIcon to iconName with correct props * update stories and tests accordingly
e1d4b22 to
d397995
Compare
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
LGTM, thanks for the follow-up fixes!
|
@edlerd the snapshot failed, I'll re run the test and push it. |
|
@edlerd thanks for reviewing, I have pushed the updated snapshot. |
|
Thanks for your contributions @mushroomgenie ! |
|
🎉 This PR is included in version 4.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Done
QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:yarn buildandnpm backis successfull.Install the resulting tarball in your project with:
QA steps
Percy steps
Fixes
Fixes: #1365 .