Repository navigation
patch(DPE-10925): add LDAP docs - #856
Conversation
izmalk
left a comment
izmalk
left a comment
There was a problem hiding this comment.
The guide looks nice, but if I understand correctly, the functionality itself is very new and might have some quirks to polish later.
For now, I've spotted a few possible improvements. The TODO's fixing is blocking, the rest are optional.
|
|
||
| You'll need: | ||
|
|
||
| - Charmed OpenSearch - Revision #todo add revision or higher |
There was a problem hiding this comment.
Removed all the revision todos, will add them once the charm is published
There was a problem hiding this comment.
Question: Do you want to merge this docs PR before or after the charm is published?
izmalk
left a comment
izmalk
left a comment
There was a problem hiding this comment.
Looks good.
I would really prefer to have a note stating the minimum revision of the OS charm for this feature to work.
Also, one small wording suggestion (non-blocking).
Co-authored-by: Vladimir Izmalkov <48120135+izmalk@users.noreply.github.com>
izmalk
left a comment
izmalk
left a comment
There was a problem hiding this comment.
Todo: one small fix for a regression introduced by last commit.
3 participants
Adds LDAP docs