Repository navigation
[gui] Flutter unit tests: Dropdown and Confirm dialog tests - #5385
Open
sharder996 wants to merge 5 commits into
Open
sharder996 wants to merge 5 commits into
sharder996 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
0 open findings
What changed in this PR
Adds Flutter widget tests for the custom dropdown and confirmation dialog, with safer handling of invalid dropdown values.
Changes:
- Tests dropdown rendering, interaction, sizing, disabled state, and edge cases.
- Tests confirmation dialog callbacks and dismissal.
- Ignores invalid dropdown values safely.
| File | Description |
|---|---|
src/client/gui/test/dropdown_test.dart |
Dropdown widget coverage |
src/client/gui/test/confirmation_dialog_test.dart |
Confirmation dialog coverage |
src/client/gui/lib/dropdown.dart |
Invalid-value handling |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sharder996
requested review from
a team and
jimporter
and removed request for
a team
October 7, 2026 20:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5385 +/- ##
==========================================
+ Coverage 72.26% 75.19% +2.93%
==========================================
Files 347 353 +6
Lines 20627 22446 +1819
==========================================
+ Hits 14905 16876 +1971
+ Misses 5722 5570 -152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sharder996
marked this pull request as draft
October 21, 2026 14:30
sharder996
marked this pull request as ready for review
October 21, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the next in line for adding unit testing in the GUI. This time we test the custom Dropdown used in the GUI and the Confirmation dialog.
Some edits were made to the GUI production code in order to cover some edge cases that were previously uncovered.
MULTI-2521