Various improvements to target handling - #52
Merged
Merged
Conversation
calebzulawski
commented
Aug 14, 2026
Owner
- Rely on rustc for implied feature handling
- Remove CPU multiversion targets due to instability between rustc versions
- Expand and correct simd targets (fixes simd enables avx2 without bmi2 #51)
- Make target-features dependency optional
Contributor
There was a problem hiding this comment.
Pull request overview
Improves target parsing, SIMD coverage, feature gating, and no_std support.
Changes:
- Delegates feature validation to rustc and removes CPU specifications.
- Expands SIMD targets with version/nightly gating.
- Makes
target-featuresoptional and strengthens CI coverage.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Updates MSRV badge. |
multiversion/tests/simd.rs |
Adds nightly architecture gates. |
multiversion/tests/helpers.rs |
Gates optional dependency tests. |
multiversion/tests/cfg.rs |
Updates target configuration tests. |
multiversion/src/lib.rs |
Adds no_std and feature gating. |
multiversion/Cargo.toml |
Defines MSRV and optional features. |
multiversion-macros/src/target.rs |
Simplifies target parsing. |
multiversion-macros/src/simd.rs |
Defines expanded SIMD targets. |
multiversion-macros/src/multiversion.rs |
Uses centralized SIMD targets. |
multiversion-macros/src/lib.rs |
Registers SIMD and target macros. |
multiversion-macros/src/dispatcher.rs |
Generates deferred selected-target macros. |
multiversion-macros/Cargo.toml |
Updates features and dependencies. |
CHANGELOG.md |
Documents user-facing changes. |
Cargo.lock |
Updates dependency resolution. |
.github/workflows/ci.yml |
Expands platform and feature coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
calebzulawski
force-pushed
the
target-fixes
branch
from
August 14, 2026 21:47
03c6a9f to
042d65b
Compare
|
Is there any timeline for when this is going to ship to crates.io? I'd like to be able to point people to the |
Owner
Author
|
I'll see if I can get a release this weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.