docs: retire never-run cargo-vet config and its claims (LAB-3029) - #281
Conversation
…(LAB-3029) cargo-vet has never run in this repo (no CI/Makefile/pre-commit consumer, zero audits ever recorded, 149/316 exemptions reference crates absent from Cargo.lock) while SECURITY.md and DEVELOPMENT.md claimed it as an active control with a Q1-2026 completion date. Retire the dead config and the false claims rather than adopt the tool; fix the dead cachekit-core cross-repo anchor along the way since it lives in the same section.
|
Warning Review limit reachedNext included review available in 14 seconds. View limit detailsLimit details: You’ve used the included review currently available. Your 103 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Comment |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Summary
Follow-up to LAB-3016 / #280. Grooming found the "stale blake3 exemption" was a symptom of a larger trust bug: cargo-vet has never run in this repo.
rust/supply-chain/was acargo vet initsnapshot from the 2025-12-10 alpha, never invoked by CI,rust/Makefile, or.pre-commit-config.yaml.audits.toml/imports.lockrecorded zero audits ever. 149 of 316 exempted crates are absent from the rootCargo.lock.SECURITY.mdandDEVELOPMENT.mdpresented it as an active control with a "Q1 2026" completion target that passed six months ago.SECURITY.md's[core-supply-chain]anchor pointed at a heading that doesn't exist incachekit-core/SECURITY.md(404s silently to the top of the file); the real heading is### Dependencies.Decision: retire, don't adopt (attention protocol, Ray 2026-08-04; precedent: docs gate 2026-07-20 + LAB-1037). Adopting cargo-vet for real is a separate Size L+ ticket if wanted — this PR only removes the false posture claim.
Changes
rust/supply-chain/{config.toml,audits.toml,imports.lock}.SECURITY.md: dropped the cargo-vet table row, the "Audit status: In progress (Q1 2026…)" line, and the Q1-2026 cargo-vet roadmap row (Q2–Q4 rows untouched, out of scope). Added the cargo-audit row actually enforced bysecurity-fast.yml. Fixed the cargo-deny config path (rust/deny.toml→deny.toml, which is where the file actually lives). Renamed "Supply Chain Security" → "Dependency Security" (heading, TOC anchor, and thecore-supply-chainreference-link id →core-deps) so no stray anchor/link-id still contains "supply-chain" — verified nothing outside this file links to the old anchor. Fixed the deadcachekit-corecross-repo anchor to#dependencies(verified: exactly one### Dependenciesheading incachekit-core/SECURITY.md).DEVELOPMENT.md: removed thesupply-chain/tree line, swapped cargo-vet → cargo-audit in the Rust security-stack table, deleted the "cargo-vet Exemptions" troubleshooting section.README.md: same retired terminology in its security-tooling bullet list ("Supply Chain Security" → "Dependency Security", explicitly credits cargo-audit rather than implying it via "RustSec scanning") — caught by the expert-panel review as a doc surface this change touches.No workflow files touched;
security-fast.ymlis unchanged and still runs cargo-audit + cargo-deny.Verification
grep -rn -i -E 'cargo.?vet|supply-chain' --exclude-dir=.git .→ zero hits.deny.tomlconfirmed at repo root (notrust/deny.toml).cachekit-core/SECURITY.mdconfirmed to have exactly one### Dependenciesheading (line 62); no external repo links to the old#supply-chain-securityanchor on this file (org-widegh search code).Expert-panel review (LAB-2707/workspace gate — Size S, not trivial-exemptible)
Ran bug-hunter-supreme, security-specialist, code-craftsman, catchphrase-agent in parallel.
deny.toml/security-fast.yml/thecachekit-coreanchor all check out; framed the retired false claim itself as the CWE-1059-style misleading-documentation defect this PR fixes.README.md:301carried the same retired "Supply Chain Security" terminology without naming cargo-audit. Applied (see README.md change above).Docs gate
This PR is the docs pass for LAB-3029.
docs.cachekit.io(cachekit-io/docs) has no cargo-vet mention (org-wide search, 2026-09-06) — no docs-site change needed.Test plan
grep -rn -i -E 'cargo.?vet|supply-chain' --exclude-dir=.git .returns zero hits.github/workflows/*files modified