chore(test): drop fixed --basetemp from addopts (LAB-2814) - #278
Open
27Bslash6 wants to merge 1 commit into
Open
chore(test): drop fixed --basetemp from addopts (LAB-2814)#27827Bslash6 wants to merge 1 commit into
27Bslash6 wants to merge 1 commit into
Conversation
Two concurrent pytest sessions on one host can corrupt each other's temp directories due to the fixed /tmp/pytest path being deleted and recreated by each session. Pytest's default (system temp with numbered, lock-protected dirs) is collision-safe and requires no configuration.
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes concurrent pytest sessions corrupting each other's temp directories.
Two concurrent pytest runs on one host with
--basetemp=/tmp/pytestcompete to delete and recreate the same directory, causing spurious test failures in the File backend tests (tmp_path corruption).Removing the fixed basetemp uses pytest's default collision-safe numbering in system temp. Verified with two concurrent runs on test_file_backend.py — both pass.