Repository navigation
Updating mobiledoc property does not work #164
Description
The {{mobiledoc-editor}} component does not implement didReceiveAttrs() and so does not properly handle having the mobiledoc change out from under it.
As an aside, I have no idea how to supply a new mobiledoc to an editor instance. Seems like maybe it's not possible...?
Activity
sdhull commentedon Dec 17, 2018
OK after more investigation, I realize it works as long as it's a new
mobiledochash that the component has never received before.However, if I send a default mobiledoc to the component (with an empty section, due to autofocus issue), that will cache the document as
_upstreamMobiledoc. Then someone uses the editor, causing_localMobiledocto be set. But when I want to reset the form, I resend that empty mobiledoc and it does nothing (because that default mobiledoc has been cached as_upstreamMobiledoc.I don't know if the editor component hangs on to two references to mobiledocs for any purpose, but if not, I'd collapse
_upstreamMobiledocand_localMobiledocinto a single_mobiledocproperty and that would solve the problem. PR incoming.sdhull commentedon Dec 17, 2018
(and turns out using
willRenderinstead ofdidReceiveAttrsis fine)