Repository navigation
Compile finite volume implementation only once - #3405
Conversation
ZedThree
left a comment
There was a problem hiding this comment.
Nice! Very clever implementation of this.
There's just a few bits of commented out code to clean up, and as we're touching this, may as well fix the clang-tidy warnings. Then we're ratcheting our way to being totally warning clean!
It would also be good to just add something to the docstrings of these functions about how to add a new limiter without upstreaming it.
Co-authored-by: Peter Hill <zed.three@gmail.com>
|
Please could you just add something about needing to include |
|
Sorry, forgot about them. Should be good now. |
|
Now we could also make this a configurable runtime choice. |
ZedThree
left a comment
There was a problem hiding this comment.
Making it a runtime choice would be neat, but can be done later
The BOUT++ provided slope limiters are all instantiated, using the previous header file.
If a user wants to use a different slope limiter, they can
#includethe implementation header (or just upstream, as one should).