DNM CI: investigate tests KVM regression#56
Merged
Conversation
The systemd 255.4-1ubuntu8.16 update from noble-updates breaks /dev/kvm passthrough into podman containers. Pin to .15 to verify this is the root cause before filing an upstream issue. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins systemd and related libraries to version 255.4-1ubuntu8.15 in the integration test CI workflow to diagnose a KVM passthrough regression introduced by a newer noble-updates release. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this is a temporary debugging pin, consider adding an inline comment in the workflow near the package list explaining the KVM regression context and any tracking issue/bug so it’s clear when it can be removed.
- Pinning core packages to an exact version in CI can start failing once that version is removed from the mirror; you may want to add a fallback strategy (e.g., a conditional install or an apt preference file) so the workflow degrades gracefully when 255.4-1ubuntu8.15 is no longer available.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this is a temporary debugging pin, consider adding an inline comment in the workflow near the package list explaining the KVM regression context and any tracking issue/bug so it’s clear when it can be removed.
- Pinning core packages to an exact version in CI can start failing once that version is removed from the mirror; you may want to add a fallback strategy (e.g., a conditional install or an apt preference file) so the workflow degrades gracefully when 255.4-1ubuntu8.15 is no longer available.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pin libudev-dev and other systemd reverse dependencies to .15 to prevent apt from pulling in .16 transitively. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The systemd 255.4-1ubuntu8.16 upgrade resets /dev/kvm permissions. Move chmod 666 /dev/kvm after the package install step so it runs after any udev changes take effect. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The systemd 255.4-1ubuntu8.16 update from noble-updates breaks /dev/kvm passthrough into podman containers.
CI: