Skip to content

DNM CI: investigate tests KVM regression#56

Merged
alicefr merged 3 commits into
mainfrom
investigate-ci-failure
Jun 9, 2026
Merged

DNM CI: investigate tests KVM regression#56
alicefr merged 3 commits into
mainfrom
investigate-ci-failure

Conversation

@alicefr

@alicefr alicefr commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

The systemd 255.4-1ubuntu8.16 update from noble-updates breaks /dev/kvm passthrough into podman containers.
CI:

  • Update integration test GitHub Actions workflow to install systemd and related packages at version 255.4-1ubuntu8.15 for reproducible CI runs.

The systemd 255.4-1ubuntu8.16 update from noble-updates breaks
/dev/kvm passthrough into podman containers. Pin to .15 to verify
this is the root cause before filing an upstream issue.

Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins systemd and related libraries to version 255.4-1ubuntu8.15 in the integration test CI workflow to diagnose a KVM passthrough regression introduced by a newer noble-updates release.

File-Level Changes

Change Details Files
Pin systemd and related packages to a specific version in CI integration test environment to bisect a KVM passthrough regression.
  • Extend the apt-get build dependencies install step in the integration-tests GitHub Actions workflow.
  • Add explicit version pin for systemd to 255.4-1ubuntu8.15.
  • Add matching version pins for libsystemd0, libsystemd-shared, libudev1, and udev to 255.4-1ubuntu8.15 to keep the stack consistent.
.github/workflows/integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since this is a temporary debugging pin, consider adding an inline comment in the workflow near the package list explaining the KVM regression context and any tracking issue/bug so it’s clear when it can be removed.
  • Pinning core packages to an exact version in CI can start failing once that version is removed from the mirror; you may want to add a fallback strategy (e.g., a conditional install or an apt preference file) so the workflow degrades gracefully when 255.4-1ubuntu8.15 is no longer available.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since this is a temporary debugging pin, consider adding an inline comment in the workflow near the package list explaining the KVM regression context and any tracking issue/bug so it’s clear when it can be removed.
- Pinning core packages to an exact version in CI can start failing once that version is removed from the mirror; you may want to add a fallback strategy (e.g., a conditional install or an apt preference file) so the workflow degrades gracefully when 255.4-1ubuntu8.15 is no longer available.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

alicefr added 2 commits June 9, 2026 08:21
Pin libudev-dev and other systemd reverse dependencies to .15 to
prevent apt from pulling in .16 transitively.

Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The systemd 255.4-1ubuntu8.16 upgrade resets /dev/kvm permissions.
Move chmod 666 /dev/kvm after the package install step so it runs
after any udev changes take effect.

Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alicefr alicefr changed the title DNM CI: pin systemd to 255.4-1ubuntu8.15 to test KVM regression DNM CI: investigate tests KVM regression Jun 9, 2026
@alicefr alicefr merged commit 8b0c9d1 into main Jun 9, 2026
4 of 5 checks passed
@alicefr alicefr deleted the investigate-ci-failure branch June 18, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant