Repository navigation
fix: lower CMake requirement to 3.10, raise policy max to 4.4 - #435
Merged
Merged
Conversation
FindPython3 was the only 3.12 dependency; on older CMake the two Python consistency checks are skipped (they still run in CI). Standalone builds on older CMake also skip the benchmarks, since google/benchmark requires 3.13. Raising the policy max to 4.4 needs CMP0169 set to OLD for BoostFetch.cmake's FetchContent_Populate. Fixes boostorg#417 Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting 3.10 on macOS ARM was "fun". Finally just used a docker container.
🤖 AI text below 🤖
Fixes #417.
FindPython3 (added in CMake 3.12) was the only thing that needed 3.12. On older CMake, the two Python consistency checks are skipped with a status message; they still run in CI. Two more changes surfaced while testing the full range:
FetchContent_Populatein BoostFetch.cmake an error, so the standalone path sets it to OLD.Verified the standalone configure/build/ctest on CMake 3.10.2 (Ubuntu 18.04 container) and 4.4.0 (macOS).