Repository navigation
chore: move b2 project requirements out of build.jam - #433
Merged
Merged
Conversation
<local-visibility>hidden as a global project requirement leaks into the install targets that boost-library generates and breaks alternative selection when building the Boost superproject. The warning flags, /bigobj, and hidden visibility only matter when compiling tests and examples, so move them into test/Jamfile and examples/Jamfile. Fixes boostorg#425 Assisted-by: ClaudeCode:claude-fable-5
henryiii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not know much about b2, but this was able to make a super project checkout and recreated the original issue, and this fix fixes it.
🤖 AI text below 🤖
Fixes #425.
<local-visibility>hiddenin the global project requirements leaks into the install targets thatboost-librarygenerates and breaks alternative selection when building the Boost superproject. The warning flags,/bigobj, and hidden visibility only matter when compiling tests and examples, so this moves all requirements (and the<warnings>extradefault-build) intotest/Jamfileandexamples/Jamfile, leavingproject /boost/histogram ;as suggested in the issue.The hidden-visibility setting dates back to #361, where it was added so the tests compile the way Python-wheel builds do; keeping it in the test/example projects preserves that.
Verified in a fresh superproject checkout:
b2 -n libs/histogram//install-libraries-sharedreproduces theno match: <local-visibility>hiddenoutput before the change (also on macOS) and resolves cleanly after; test compiles still get-fvisibility=hidden -fvisibility-inlines-hidden, andtest//minimalpasses.