Implement restoring last power state of bluetooth adapter(s)#3244
Open
infirit wants to merge 4 commits into
Open
Implement restoring last power state of bluetooth adapter(s)#3244infirit wants to merge 4 commits into
infirit wants to merge 4 commits into
Conversation
Contributor
Author
|
Sonar cloud was right to complain with the old error message but I disagree with it to use |
Also make the variables a little more clear.
Sonarcloud is right to complain with the old message.
|
cschramm
approved these changes
Jun 14, 2026
cschramm
left a comment
cschramm
left a comment
Member
There was a problem hiding this comment.
I am not really convinced if this should be blueman's business, but it's definitely a nice option.
| <key type="mb" name="restore-power-state"> | ||
| <default>nothing</default> | ||
| </key> | ||
| </schema> |
Member
There was a problem hiding this comment.
Suggested change
| </schema> | |
| </schema> |
| "default": False | ||
| }, | ||
| "restore-power-state": { | ||
| "type": bool, |
Member
There was a problem hiding this comment.
This does not match mb. I think get_option might actually return None and set_option will just never write None. It probably makes sense to just use b with a false default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off by default but I think this is reasonable. Bluedevil has a similar feature.